-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add explicit root TLS configuration to gRPC clients #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allthatjazzleo
force-pushed
the
fix/tonic-0.12
branch
from
August 24, 2024 06:21
646f119
to
bca7eb7
Compare
allthatjazzleo
changed the title
fix: add explicit root tls
fix: add explicit root tls configuration
Aug 24, 2024
Good catch, thanks for opening this PR, much appreciated! We'll take a look ASAP! |
romac
changed the title
fix: add explicit root tls configuration
fix: Add explicit root TLS configuration to gRPC clients
Aug 26, 2024
LGTM, thanks a lot! |
ljoss17
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling this!
@allthatjazzleo Can you please add a changelog entry in |
allthatjazzleo
force-pushed
the
fix/tonic-0.12
branch
from
August 26, 2024 15:43
cad9bbb
to
b04dd8f
Compare
@romac changelog entry done and resolve conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4160
Description
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.