Implement packet clearing in relayer next

[ljoss17]

Closes: #XXX

Description

---

PR author checklist:

• Added changelog entry, using unclog.
• Added tests: integration (for Hermes) or unit/mock tests (for modules).
• Linked to GitHub issue.
• Updated code comments and documentation (e.g., docs/).
• Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

• Reviewed Files changed in the GitHub PR explorer.
• Manually tested (in case integration/unit/mock tests are absent).

[soareschen]

I think we can move most of this module to relayer-components. The only extra part here is the worker, which requires the runtime to have spawner function, which introduces non-determinism.

[soareschen]

This seems to be rather inefficient, as one query is made per sequence. I think we should be able to use query_send_packet_events from crates/relayer/src/link/packet_events.rs to get all events in one query.

[ljoss17]

From what I understand query_send_packet_events from crates/relayer/src/link/packet_events.rs does the following:

1. Build the QueryPacketEventDataRequest and call query_packet_events
2. If the height is Qualified::Equal query the packets from block (not currently done in the this implementation for relayer-next)
3. If the height is Qualified::SmallerEqual query the packets from TXs
4. query_packet_from_txs calls tx_search(packet_query(..)) for each sequence number, similar to what is being done in this implementation
   1. With the addition of mapping the ABCI events to IbcEventWithHeight by calling packet_from_tx_search_response.

I don't see how this is more efficient, and the issue is that the cosmos implementation uses ABCI Events as its Event type so try_extract_send_packet_event expects an ABCI Event and not a IbcEventWithHeight.

And query_packet_events_with from crates/relayer/src/link/packet_events.rs is called with query_send_packet_events and query_write_ack_events as query_fn, so it also ends up calling query_packet_events.

[soareschen]

Hmm you are right. Looks like the algorithm is ultimately based on query_packets_from_txs in crates/relayer/src/chain/cosmos/query/tx.rs. Maybe we should note that down and add a todo for investigating more efficient approach.

One more nit for this: it should be possible to use the Stream construct with .map() to query for all events in parallel and then collect them into a vec.

[soareschen]

Probably a more structured way to define this is to first define a singular CanQuerySendPacketsFromSequence trait (without -s), and then implement CanQuerySendPacketsFromSequences by using Stream::map and calling the singular method for each sequence.

[soareschen]

Maybe it makes sense to move the concrete implementation for try_extract_write_acknowledgement_event and try_extract_send_packet_event into methods/ so that we can call it directly as plain function.

[soareschen]

I think we can call relay_context.relay_a_to_b().src_chain().query_unreceived_packet_sequences() directly.

Since relay_context.relay_a_to_b() is called repeatedly, we can simplify it by assigning it a variable like let relay = birelay.relay_a_to_b();. Similarly we can assign let chain_a = relay.src_chain();.

[ljoss17]

Fixed in e0b5727

[soareschen]

The name of the method should also change to query_send_packets_from_sequences. Also, let's move this trait to a separate file like send_packets.rs.