Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Neutron to integration tests #3388

Closed
wants to merge 2 commits into from
Closed

Add Neutron to integration tests #3388

wants to merge 2 commits into from

Conversation

romac
Copy link
Member

@romac romac commented Jun 2, 2023

Closes: #3387

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac requested a review from ljoss17 June 2, 2023 07:26
@ljoss17
Copy link
Contributor

ljoss17 commented Jun 5, 2023

It seems the genesis file has a difference with max_deposit_period in the genesis file. I'll look into this as soon as I have some spare time

@romac romac marked this pull request as draft June 8, 2023 09:41
@ljoss17
Copy link
Contributor

ljoss17 commented Aug 2, 2023

Closing this as it was completed by #3451

@ljoss17 ljoss17 closed this Aug 2, 2023
@romac romac deleted the romac/add-neutron branch November 22, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Neutron in integration tests
2 participants