Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GAT to define generic MPSC channel context #2935

Merged
merged 32 commits into from
Dec 15, 2022
Merged

Use GAT to define generic MPSC channel context #2935

merged 32 commits into from
Dec 15, 2022

Conversation

soareschen
Copy link
Contributor

@soareschen soareschen commented Dec 12, 2022 •
edited
Loading

Closes: #2816

Blocked on: #2932

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@soareschen soareschen changed the base branch from master to soares/relayer-next December 12, 2022 11:44
@netlify
Copy link

netlify bot commented Dec 12, 2022

👷 Deploy Preview for ibc-rs processing.

Name Link
🔨 Latest commit eccdc19
🔍 Latest deploy log https://app.netlify.com/sites/ibc-rs/deploys/639729d1180039000965a4ba

@netlify
Copy link

netlify bot commented Dec 12, 2022 •
edited
Loading

✅ Deploy Preview for ibc-rs ready!

Name Link
🔨 Latest commit 69a5583
🔍 Latest deploy log https://app.netlify.com/sites/ibc-rs/deploys/639734cb426955000898e074
😎 Deploy Preview https://deploy-preview-2935--ibc-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@soareschen soareschen marked this pull request as ready for review December 12, 2022 13:19
@soareschen soareschen added the O: relayer-next Objective: work toward relayer v2 label Dec 12, 2022
@soareschen
Copy link
Contributor Author

I will merge this first to reduce the rate of having merge conflicts with other PRs.

@soareschen soareschen merged commit 869278d into soares/relayer-next Dec 15, 2022
@soareschen soareschen deleted the soares/gat-batch-context branch December 15, 2022 22:18
@soareschen soareschen mentioned this pull request Dec 16, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljoss17 ljoss17 Awaiting requested review from ljoss17

@seanchen1991 seanchen1991 Awaiting requested review from seanchen1991

Assignees
No one assigned
Labels
O: relayer-next Objective: work toward relayer v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use GAT to define generic MPSC channel context
1 participant
@soareschen