-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Localchain feature #289
Conversation
This PR is currently on hold. Partly because this is blocked on tendermint-rs side, partly because fixing cosmos/ibc-rs#111 takes priority for the moment. |
Codecov Report
@@ Coverage Diff @@
## master informalsystems/hermes#289 +/- ##
=========================================
+ Coverage 13.6% 37.0% +23.3%
=========================================
Files 69 129 +60
Lines 3752 8390 +4638
Branches 1374 2905 +1531
=========================================
+ Hits 513 3106 +2593
- Misses 2618 5105 +2487
+ Partials 621 179 -442
Continue to review full report at Codecov.
|
We're abandoning this PR in favor of two smaller ones. We'll have one PR that focuses exclusively on modifications for the |
* Bringing changes from the older PR #289, first pass. * Second pass * Third pass done, finished bringing old changes. * Updated changelog * Removed useless test conditional compilation. * Clippy exceptions to disable dead code warning * Removing dep on the dev branch * Update tendermint-testgen dependency Signed-off-by: Thane Thomson <[email protected]> * Prep context to store multiple types of clients. Deleted mock error. * Moved module mock_client into mock * Generalized MockClientRecord * with_client_parametrized done * Added basic implementation for TM::check_header_and_update_state. * Apply suggestions from code review Applied Anca's comments Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Thane Thomson <[email protected]> Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Anca Zamfir <[email protected]>
* Bringing changes from the older PR informalsystems#289, first pass. * Second pass * Third pass done, finished bringing old changes. * Updated changelog * Removed useless test conditional compilation. * Clippy exceptions to disable dead code warning * Removing dep on the dev branch * Update tendermint-testgen dependency Signed-off-by: Thane Thomson <[email protected]> * Prep context to store multiple types of clients. Deleted mock error. * Moved module mock_client into mock * Generalized MockClientRecord * with_client_parametrized done * Added basic implementation for TM::check_header_and_update_state. * Apply suggestions from code review Applied Anca's comments Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Thane Thomson <[email protected]> Co-authored-by: Anca Zamfir <[email protected]> Co-authored-by: Anca Zamfir <[email protected]>
Closes: #158 (not ready!)
Before merging:
git
options from the cargo's toml files and pin against a release.For contributor use:
docs/
) and code commentsFiles changed
in the Github PR explorer