Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Any* enums #2338

Closed
wants to merge 46 commits into from
Closed

Remove Any* enums #2338

wants to merge 46 commits into from

Conversation

hu55a1n1
Copy link
Member

Closes: #2335

Description

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@hu55a1n1
Make ConsensusState object-safe
25ae321
@hu55a1n1
Make ClientState trait object safe
8de05d8
@hu55a1n1
Extract ConsensusReader
e92fe1f
@hu55a1n1
Fix clippy errors
0ac6754
@hu55a1n1
Remove all Any* usages from clients
b319ef1
@hu55a1n1
Merge remote-tracking branch 'origin/master' into hu55a1n1/light-clie…
406eaed 
…nt-crates
@hu55a1n1
Remove client specific errors from Ics02Error
107b2c4
@hu55a1n1
Extract ChannelMetaReader
6839a36
@hu55a1n1
Fix Ci
51562ee
@hu55a1n1
Remove unnecessary Clone supertrait from Header & Misbehaviour
d1a7100
@hu55a1n1
Fix bad std import
b11e440
@hu55a1n1
Remove redundant Clone supertrait from ClientDef
5df6b87
@hu55a1n1
Rename ConsensusReader -> LightClientReader
f0ff012
@hu55a1n1
Add docstring for LightClientReader
a914b5b
@hu55a1n1
Add docstring for ChannelMetaReader
b4ecd60
@hu55a1n1
Merge remote-tracking branch 'origin/master' into hu55a1n1/remove-cli…
310d796 
…ents-any-enums-usages
@hu55a1n1
Rename AsAny -> AsAnyConsensusState and polish it
0a3a3ad
@hu55a1n1
Add boilerplate for downcast support for Header trait
07b9394
@hu55a1n1
Replace ClientDef::Header assoc type with &dyn Header
4a393fe
@hu55a1n1
Fix clippy warnings
aa80261
@hu55a1n1
Move tendermint specific client event code into relayer crate
e530589
@hu55a1n1
Make ClientState object safe
fe50148
@hu55a1n1
Add AsAny for ClientState
6faf9bd
@hu55a1n1
Provide boxed() method for light client traits
5d11e7f
@hu55a1n1
Make ClientDef object safe
66fee9b
@hu55a1n1
Add doc string for ClientReader methods
030eb36
@hu55a1n1
Make ClientState::expired() and ConsensusState::timestamp() trait met…
b8a6f65 
…hods
@hu55a1n1
Define UpdatedState struct
d2b130b
@hu55a1n1
Update relayer code to use ConsensusState::timestamp()
24bd63f
@hu55a1n1
Use boxed API for client handlers
2966877
@hu55a1n1 hu55a1n1 mentioned this pull request Jul 29, 2022
Merged
20 tasks
@hu55a1n1
Copy link
Member Author

Superseded by #2483.

@hu55a1n1 hu55a1n1 closed this Aug 17, 2022
@romac romac deleted the hu55a1n1/remove-any-enums branch November 22, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract light client implementations into separate crates
1 participant
@hu55a1n1