Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ics07 unwrap() and update ibc protocol spec link #2115

Merged
merged 3 commits into from
Apr 25, 2022
Merged

Remove ics07 unwrap() and update ibc protocol spec link #2115

merged 3 commits into from
Apr 25, 2022

Conversation

DaviRain-Su
Copy link
Contributor

Description

  • remove ics07-tendemrint client_def.rs unwrap()
  • update ibc protocol spec link

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

adizere
adizere approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DaviRain-Su !

@adizere
Copy link
Member

adizere commented Apr 25, 2022

Please feel free to merge. It's only important to do a cargo fmt --all before that.

@romac romac merged commit dee7489 into informalsystems:master Apr 25, 2022
@DaviRain-Su DaviRain-Su deleted the feature/remove-unwrap-and-update-link branch April 25, 2022 09:22
@hu55a1n1
Copy link
Member

Related: encode_vec() will be infallible once this PR is included in a tendermint-rs release informalsystems/tendermint-rs#1064.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaviRain-Su @adizere @hu55a1n1 @romac