Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non-standard ports in channel handshake #1840

Merged
merged 5 commits into from
Feb 4, 2022
Merged

Handle non-standard ports in channel handshake #1840

merged 5 commits into from
Feb 4, 2022

Conversation

romac
Copy link
Member

@romac romac commented Feb 3, 2022 •
edited
Loading

Closes: #1837

Description

Handle non-standard ports in channel handshake by using the empty version string when the port is unknown, and leave it to the application to negotiate the proper version in the OnChanOpenTry callback.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac mentioned this pull request Feb 3, 2022
Closed
@romac
Use empty version for ChanOpenInit when port is non-standard and so…
da70b4c 
…urce channel version for `ChanOpenTry` steps
@romac romac force-pushed the romac/1837-non-standard-port branch from 690c16b to da70b4c Compare February 3, 2022 14:47
@adizere adizere mentioned this pull request Feb 3, 2022
Merged
6 tasks
This was referenced Feb 4, 2022
Closed
Closed
adizere
adizere approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just an error type cleanup may be needed.

relayer/src/channel/error.rs Outdated Show resolved Hide resolved
@romac romac marked this pull request as ready for review February 4, 2022 10:17
@romac romac merged commit 1a69c4d into romac/1797-ibc-v3 Feb 4, 2022
@romac romac deleted the romac/1837-non-standard-port branch February 4, 2022 11:59
@michaelfig michaelfig mentioned this pull request Feb 4, 2022
Closed
5 tasks
@romac romac mentioned this pull request Feb 18, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romac @adizere