Allow ChainEndpoint implementations to fetch any types of clients and consensus states
#1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was previously returning `Self::ConsensusState` instead of `AnyConsensusState` which made it impossible to implement it for non-Cosmos chains since it would force the implementation to return a `Self::ConsensusState` even when the given client id corresponds to another type of client with a different consensus state.
romac
changed the title
ChainEndpoint implementations to fetch any types of clients and consensus states
|
@lightyear15 and @hu55a1n1, can you help with reviewing this, once it's marked ready for review? I think the PR is almost there. We don't have any automated tests to cover the upgrade CLIs & functionality, so we may need to test that manually. |
lightyear15
reviewed
Jan 17, 2022
|
Tested the upgrade functionality manually with gaiad v6.0.0 and it seems to work as expected. 👍 |
…count for any client types
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…nd consensus states (informalsystems#1625)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1481
TODO
For contributor use:
unclog.docs/) and code comments.Files changedin the Github PR explorer.