Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ics24_host::path module public #1499

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Make ics24_host::path module public #1499

merged 1 commit into from
Oct 26, 2021

Conversation

seanchen1991
Copy link
Contributor

@seanchen1991 seanchen1991 commented Oct 25, 2021 •
edited
Loading

Closes: #1460

Description

Totally forgot on my last PR to make the path module public, so making that change here now 😅

Also added .DS_Store files to the project's .gitignore.

For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@adizere adizere merged commit a3b1727 into informalsystems:master Oct 26, 2021
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@seanchen1991
Make ics24_host::path public (informalsystems#1499)
abe0cbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement FromStr<Path> for ics24_host::Path
2 participants
@seanchen1991 @adizere