Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICS29 packets are not filtered during packet clearing #4176

Open
5 tasks
ljoss17 opened this issue Aug 30, 2024 · 0 comments
Open
5 tasks

ICS29 packets are not filtered during packet clearing #4176

ljoss17 opened this issue Aug 30, 2024 · 0 comments

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Aug 30, 2024

Version

Latest master commit: ccd1d90

Summary of Bug

The packet_filter.min_fees configuration:

hermes/config.toml

Line 420 in ccd1d90

# [chains.packet_filter.min_fees.'*']

Is not applied when packet are being cleared.

As long as packet clearing is not disabled, if a delay long enough is set before this assertion:

hermes/tools/integration-test/src/tests/fee/filter_fees.rs

Line 110 in ccd1d90

chain_driver_b.assert_eventual_wallet_amount(

The test will fail as the packet clearing will have relayed the packet.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Aug 30, 2024
yito88 added a commit to heliaxdev/hermes that referenced this issue Nov 4, 2024
@yito88
workaround for informalsystems#4176
df9e517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Hermes
Status: 🩹 Triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ljoss17