Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo the changes introduced in #2332 #2412 and #2483 #2715

Closed
3 tasks
Tracked by #2710
romac opened this issue Oct 7, 2022 · 3 comments
Closed
3 tasks
Tracked by #2710

Undo the changes introduced in #2332 #2412 and #2483 #2715

romac opened this issue Oct 7, 2022 · 3 comments
Assignees
Milestone

Comments

@romac
Copy link
Member

romac commented Oct 7, 2022

Follow-up to #2710.

The idea is to undo (some of) the changes introduced in the following PRs, to keep the definitions in ibc-relayer-types as canonical as possible, without object safety concerns.

This means that we have to re-introduce the Any[Header,Client,etc.] enums in the relayer-types crate, but perhaps there is a better design to be found.

@romac romac changed the title Undo the changes introduced in Undo the changes introduced in #2332 #2412 and #2483 Oct 7, 2022
@romac romac added this to the v1.2 milestone Oct 7, 2022
@romac romac self-assigned this Oct 7, 2022
@adizere
Copy link
Member

adizere commented Oct 31, 2022

Seems done, thank you Romain!

@adizere adizere closed this as completed Oct 31, 2022
@romac romac reopened this Oct 31, 2022
@romac
Copy link
Member Author

romac commented Oct 31, 2022

It's not actually done, but we may want to discuss which parts of this we actually want to revert. Not a priority right now though so let's push it to 1.3.

@romac romac modified the milestones: v1.2, v1.3 Oct 31, 2022
@adizere adizere added this to Hermes Dec 13, 2022
@adizere adizere moved this to 📋 Backlog in Hermes Dec 13, 2022
@seanchen1991 seanchen1991 modified the milestones: v1.3, Backlog Dec 13, 2022
@romac
Copy link
Member Author

romac commented Nov 9, 2023

Done in #3671

@romac romac closed this as completed Nov 9, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Hermes Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants