Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename leftover modules crate to ibc-relayer-types and trim it down #2710

Closed
16 tasks done
romac opened this issue Oct 6, 2022 · 0 comments · Fixed by #2711
Closed
16 tasks done

Rename leftover modules crate to ibc-relayer-types and trim it down #2710

romac opened this issue Oct 6, 2022 · 0 comments · Fixed by #2711
Assignees
Milestone

Comments

@romac
Copy link
Member

romac commented Oct 6, 2022

Summary

Rename leftover modules crate to ibc-relayer-types and clean it up to remove everything not needed by the relayer, eg. the handlers.

Problem Definition

Now that the ibc and ibc-proto crates have been split out into their own repositories, we are left with a copy of the ibc crate in the crates/modules folder.

Proposal

  • Rename the ibc crate in the crates/modules folder to ibc-relayer-types
  • Rename crates/modules to crates/relayer-types
  • Update the workspace Cargo.toml and the [dependencies] section of all crates which depend on ibc
  • Update all the import paths in all the crates which now depend on ibc-relayer-types
  • Remove all the handlers from ibc-relayer-types and all the code which depend on it
    • Handlers themselves
    • Contexts, readers and keepers
    • Mock contexts, mock chain, etc.
    • MBT tests, tests against the mock chain
  • Remove references to the mock chain and mock client from the ibc-relayer crate

Follow-up:

Acceptance Criteria

All steps above have been carried out.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant