Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversational entity linking into REL #150

Merged
merged 16 commits into from
Jan 24, 2023
Merged

Add conversational entity linking into REL #150

merged 16 commits into from
Jan 24, 2023

Conversation

stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented Dec 20, 2022

This PR implements converstational entity linking from @hideaki-j into REL.

First I refactored the CREL code (see informagi/conversational-entity-linking-2022#1). I left the code as-is as much as possible, and tried to depend on functions already in REL where possible. Then I copied all the code over into ./src/REL/crel.

I added some tests and documentation for the new CREL functions.

I also refactored the server to use fastapi/pydantic (in #147 so you can see the changes). I then branched this off #147, which makes it much easier to implement the conversational entity linking into the server. Note that the API itself did not change, I just added conversational entity linking to it. Fastapi/pydantic will make it much easier to update the API later on.

To check out the server working, see ./scripts/test_server.py for an example.

Todo

  • Align conv EL with REL itself (re-use parts where possible)
  • ConvEL has its own mention detection using Bert, this should be aligned with @eriktks work.
    -> Revisit when Mention detection with Bert #151 is merged
  • Figure out what the correct API for interacting with the server should be.
  • Update documentation (setup, paths etc, how much should this be part of REL?)

Follow-up:

@stefsmeets stefsmeets marked this pull request as ready for review January 16, 2023 13:22
@stefsmeets
Copy link
Contributor Author

Hi @chriskamphuis and @hideaki-j I think this PR is pretty much done, could you have a look at it and let me know what you think?

@chriskamphuis
Copy link
Contributor

@hideaki-j Can you look at this, as you created CREL, I am not familiar with it

@hideaki-j
Copy link
Contributor

I have skimmed through the changes of CREL parts, and it seems to be OK (Stef and I had a meeting about this and I have already shared this with him 😉) I will take the time to check the documentation and test etc in detail when I find time but I think it is good to move to the next step for now.

@stefsmeets
Copy link
Contributor Author

stefsmeets commented Jan 23, 2023

Hi @hideaki-j @chriskamphuis, if you are happy with the changes, don't forget to press the 'Approve changes' button, so that the code can be merged :-)

@stefsmeets stefsmeets merged commit 0018b57 into main Jan 24, 2023
@stefsmeets stefsmeets deleted the fastapi-conv-el branch January 24, 2023 08:09
@stefsmeets stefsmeets mentioned this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants