Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment to Network Class #170

Merged
merged 1 commit into from
Aug 31, 2017
Merged

Add comment to Network Class #170

merged 1 commit into from
Aug 31, 2017

Conversation

itdependsnetworks
Copy link
Contributor

Perhaps I am misunderstanding _return_fields as I would expect the list to be larger. For example most Class's do not have comment in there.

@codecov
Copy link

codecov bot commented Aug 19, 2017

Codecov Report

Merging #170 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   84.21%   84.21%           
=======================================
  Files           7        7           
  Lines        1147     1147           
  Branches      189      189           
=======================================
  Hits          966      966           
  Misses        134      134           
  Partials       47       47
Impacted Files Coverage Δ
infoblox_client/objects.py 86.04% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad72421...8c7119a. Read the comment docs.

@itdependsnetworks
Copy link
Contributor Author

pinging @yuewko based on previous PR's

Copy link
Contributor

@yuewko yuewko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuewko yuewko merged commit af56a85 into infobloxopen:master Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants