-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ea definition support #235
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JkhatriInfobox
force-pushed
the
ea_definition
branch
4 times, most recently
from
July 3, 2024 10:06
f71cb32
to
a4ea6e3
Compare
* Add extensible attribute module * added choices to IB_spec * doco * Add the struct creation to api * doco * pep and lint
* Extensible attributes module - support flags infobloxopen/infoblox-ansible/#186 add support for flags to the extensible attributes module * Extensible attributes - fix linting reported by the ansible sanity tests --------- Co-authored-by: Hugues Malphettes <[email protected]>
fix doco line length fix line length PEP issue pep issue
JkhatriInfobox
force-pushed
the
ea_definition
branch
from
July 3, 2024 10:44
a4ea6e3
to
a5e6c80
Compare
Updated workflow file to support ansible-stable 2.17 and removed 2.14 [FIX] coverage report for stable-2.16 [FIX] changed called_once_with to assert_called_once_with for unit tests [FIX] compact file deprication for ansible-2.17
…called_once_with for python3.12
JkhatriInfobox
force-pushed
the
ea_definition
branch
from
July 3, 2024 11:17
a5e6c80
to
ce80a39
Compare
2 tasks
JchhatbarInfoblox
requested changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update requested changes
JkhatriInfobox
force-pushed
the
ea_definition
branch
from
July 9, 2024 10:06
f2040fb
to
3981fbf
Compare
JchhatbarInfoblox
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.