Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the two options to Ipv4 to allow PXE server configuration #146

Merged
merged 6 commits into from
Sep 3, 2024

Conversation

Medalibi
Copy link
Contributor

No description provided.

@matthewdennett
Copy link
Contributor

Hi @Medalibi, I hope you can get some traction with this change. This is going to be very useful once it gets merged and released.

@ranjishmp
Copy link
Collaborator

Some UTs a failing.. Can you please clear them out?

@matthewdennett
Copy link
Contributor

Hi @Medalibi, is this PR addressing issue #94? If that is the case it might be worth mentioning in the PR description.

@Medalibi
Copy link
Contributor Author

Hi @matthewdennett, it is addressing a portion of it but not the whole thing. I was able to find the two options pxe and use_pxe on the Infoblox documentation. As for the other options, I am not very sure. In my view, addressing this is already very good as those other configs can be set from the pxe server level, which is what I already do from within my environment.

Copy link
Collaborator

@hemanthKa677 hemanthKa677 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Medalibi , Can you please share us example for testing this feature?

@JkhatriInfobox JkhatriInfobox self-requested a review August 22, 2024 05:45
Copy link
Collaborator

@JkhatriInfobox JkhatriInfobox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good for supporting nextserver parameter.

@JkhatriInfobox JkhatriInfobox merged commit b288ce3 into infobloxopen:master Sep 3, 2024
JkhatriInfobox added a commit that referenced this pull request Sep 11, 2024
* [FIX] Removed older PIP added by community PR #146

* [FIX] Sanity issue on nios_next_network
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants