Local cache to reuse db connection

migrate library not closing the db connection db show those connections
are in 'idle' state. When the count reaches the limit database is not
accessible.

so cache the db connection in a map with resouce name as key.

atlas-db-controller/controller.go

@@ -39,6 +39,7 @@ import (
 
 	"github.com/infobloxopen/atlas-db/pkg/server"
 	"github.com/infobloxopen/atlas-db/pkg/server/plugin"
+	"github.com/golang-migrate/migrate/database"
 )
 
 const controllerAgentName = "atlas-db-controller"
@@ -66,6 +67,7 @@ const (
 )
 
 var schemaStatusMsg string
+var dbDriverMap = make(map[string]database.Driver)
 
 // Controller is the controller implementation for DatabaseServer resources
 type Controller struct {
@@ -386,16 +388,29 @@ func (c *Controller) syncSchema(key string) error {
 		}
 	}
 
-	mgrt, err := migrate.New(gitURL, dsn)
+	// migrate package is not closing the dbconnnection so using a local cache reuse dbconnection.
+	// TODO when same resource with different dsn arrives; need to unset local cache during schema resource deletion.
+	dbDriver, ok := dbDriverMap[schema.Namespace + schema.Name]
+	if !ok {
+		dbDriver, err = database.Open(dsn)
+		if err != nil {
+			schemaStatusMsg = fmt.Sprintf("failed to open dbconnection: %s", err)
+			c.updateDatabaseSchemaStatus(key, schema, StateError, schemaStatusMsg)
+			err = fmt.Errorf(schemaStatusMsg)
+			runtime.HandleError(err)
+			return err
+		}
+		dbDriverMap[schema.Namespace + schema.Name] = dbDriver
+	}
+
+	mgrt, err := migrate.NewWithDatabaseInstance(gitURL, dbName, dbDriver)
 	if err != nil {
 		schemaStatusMsg = fmt.Sprintf("failed to initialize migrate engine: %s", err)
 		c.updateDatabaseSchemaStatus(key, schema, StateError, schemaStatusMsg)
 		err = fmt.Errorf(schemaStatusMsg)
 		runtime.HandleError(err)
 		return err
 	}
-	defer mgrt.Close()
-
 	ver, dirt, err := mgrt.Version()
 	if err != nil {
 		if err == migrate.ErrNilVersion {