Enable gorm filtering by Identifier #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evgeniy-L
reviewed
Aug 10, 2018
| @@ -15,7 +18,7 @@ import ( | |||
| // according to obj GORM model. If fieldPath cannot be found in obj then original fieldPath is returned | |||
| // to allow tables joined by a third party. | |||
| // If association join is required to resolve the field path then it's name is returned as a second return value. | |||
| func HandleFieldPath(fieldPath []string, obj interface{}) (string, string, error) { | |||
| func HandleFieldPath(ctx context.Context, fieldPath []string, obj interface{}) (string, string, error) { | |||
There was a problem hiding this comment.
why do we need context here?
gorm/utilities.go
Outdated
| @@ -6,7 +6,10 @@ import ( | |||
| "reflect" | |||
| "strings" | |||
|
|
|||
| "context" | |||
There was a problem hiding this comment.
please check fmt and organize imports properly.
| @@ -10,7 +11,7 @@ import ( | |||
| // - association table name | |||
| // - source join keys | |||
| // - target join keys | |||
| func JoinInfo(obj interface{}, assoc string) (string, []string, []string, error) { | |||
| func JoinInfo(ctx context.Context, obj interface{}, assoc string) (string, []string, []string, error) { | |||
There was a problem hiding this comment.
why we need context here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes: