Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/inputs/dovecot: Add support for unix domain sockets #9223

Merged
merged 1 commit into from
May 4, 2021

Conversation

isodude
Copy link
Contributor

@isodude isodude commented Apr 29, 2021

It's safer for dovecot to export metrics via a UDS instead of tcp port,
this will add support for that option.

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

resolves #9215

dovecot: Add support for unix domain sockets as well

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Apr 29, 2021
@helenosheaa
Copy link
Member

Thanks for opening the pr, overall I think it looks good. Do you think you could add a test for this extension of functionality?

It's safer for dovecot to export metrics via a UDS instead of tcp port,
this will add support for that option.
@isodude
Copy link
Contributor Author

isodude commented May 1, 2021

During testing I discovered that Server was not populated in the returned metric.
Wrote the unix socket address instead of leaving it empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input.dovecot: Add support for unix domain sockets
3 participants