Add exec plugin #92
Merged
Add exec plugin #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return err | ||
| } | ||
|
|
||
| jsonOut, err := simplejson.NewJson(out) |
There was a problem hiding this comment.
Instead of using simplejson, could we just use the standard library "encoding/json" here? I think something like this should work:
var jsonOut interface{}
err := json.Unmarshal(out, &jsonOut)
|
@alvaromorales thanks much! looks good other than I think that we can eliminate the dependency on simplejson. The reason being that telegraf can start to get pretty bloated with dependencies and I'd prefer to tend towards standard libraries where possible. |
|
Thanks for the feedback! I agree with eliminating dependencies where possible. |
srfraser
pushed a commit
to srfraser/telegraf
that referenced
this pull request
Aug 10, 2015
Add exec plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
execplugin suggested in #24. The plugin reads flattened metrics from one or more commands that output JSON to stdout.Collaborated with @jpalay