Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide test environment for kibana input plugin #8629

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

sspaink
Copy link
Contributor

@sspaink sspaink commented Dec 30, 2020

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.

To help diagnose the issue #7588, this pull request adds a test environment for the Kibana input plugin. Created a docker-compose.yml file that defines the basic components needed to use the plugin. I was able to get the expected output and wasn't able to recreate the reported issue.

The verification steps are manual, having to read the logs and attach to the container to inspect the Telegraf output file. In future pull requests, integration tests should be made to automate this. Hopefully this change will set the foundation for such tests.

@sspaink sspaink mentioned this pull request Dec 30, 2020
@lgtm-com
Copy link

lgtm-com bot commented Dec 30, 2020

LGTM pull request analysis was skipped for 6455616 by sspaink. Analysis of future commits will happen as normal.

@sspaink sspaink merged commit ee76535 into influxdata:master Jan 6, 2021
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants