Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hex_key parameter for IPMI input plugin connection #8524

Merged
merged 5 commits into from
Dec 21, 2020
Merged

Add hex_key parameter for IPMI input plugin connection #8524

merged 5 commits into from
Dec 21, 2020

Conversation

ivorybilled
Copy link
Contributor

closes #6858

@sjwang90 sjwang90 added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Dec 8, 2020
srebhan
srebhan approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small (optional) suggestion in the code, otherwise this looks good. Is there a particular reason to substitute assert.Equal by require.EqualValues in the test-code?

@srebhan srebhan self-assigned this Dec 15, 2020
@ivorybilled
Copy link
Contributor Author

Kind of just did that because I read here that 'require' is preferred. Very possible that I misunderstood though.

@srebhan
Copy link
Member

srebhan commented Dec 15, 2020

Awesome. Any thoughts on the cosmetic Connection init thingy? We can also keep as-is... Your choice!

@srebhan
Copy link
Member

srebhan commented Dec 15, 2020

Oh and can you please rebase this again to trigger CI!? Running only 2 tests seems a bit strange...

@ivorybilled
Copy link
Contributor Author

Changed it and done!

srebhan
srebhan approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 16, 2020
helenosheaa
helenosheaa approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@helenosheaa helenosheaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ivorybilled ivorybilled merged commit dd09f46 into master Dec 21, 2020
@ivorybilled ivorybilled deleted the addHexKeyParameterForIPMIConnection branch December 21, 2020 16:46
ssoroka pushed a commit that referenced this pull request Jan 27, 2021
@ivorybilled @ssoroka
Add hex_key parameter for IPMI input plugin connection (#8524)
813017c 
(cherry picked from commit dd09f46)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@ivorybilled
Add hex_key parameter for IPMI input plugin connection (influxdata#8524)
e9dad83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helenosheaa helenosheaa helenosheaa approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iDRAC 9 hex encryption Key input location
4 participants
@ivorybilled @srebhan @helenosheaa @sjwang90