-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate snmp field values #8466
Translate snmp field values #8466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LeadingMoominExpert you need to add the description of the new option also to the sampleConfig
variable.
Furthermore, I'm not sure if your testcase actually is suited to test the translate functionality as you specify the name in the tbl
. How can you see if it is actually overwritten using the translation?
@srebhan I modified the tests so that a field returns an OID value with cases of this value being translated and not translated with mocked snmptranslate command. |
I also did not include the translate functionality in telegraf/plugins/inputs/snmp/snmp.go Lines 25 to 69 in a51a9a8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. :-) Looks good.
Does this also solve #6330? And could you give an example output with the function enabled? Thanks. |
Looks like it doesn't solve it for integer fields. |
Required for all PRs:
Fixes #8458