Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix carbon2 tests #8254

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Fix carbon2 tests #8254

merged 2 commits into from
Dec 4, 2020

Conversation

zak-pawel
Copy link
Collaborator

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.
    Fixed failing carbon2 tests

@sjwang90 sjwang90 added the fix pr to fix corresponding bug label Nov 25, 2020
srebhan
srebhan approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@srebhan srebhan self-assigned this Dec 4, 2020
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 4, 2020
@zak-pawel
Copy link
Collaborator Author

Looks reasonable.

This test was fixed here: 5cc4387#diff-309697bf58aad126148c79e6801d8acd95b53a413d79522394d0c1a95d498b29 but @ssoroka had to think about using this fix instead.

@ssoroka ssoroka closed this Dec 4, 2020
@ssoroka ssoroka reopened this Dec 4, 2020
@ssoroka ssoroka merged commit 7c5754e into influxdata:master Dec 4, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@zak-pawel
Fix carbon2 tests (influxdata#8254)
3b12aee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zak-pawel @srebhan @ssoroka @sjwang90