Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update soniah/gosnmp #7836

Closed
wants to merge 3 commits into from
Closed

Update soniah/gosnmp #7836

wants to merge 3 commits into from

Conversation

danielnelson
Copy link
Contributor

Includes support for INFORM.

closes #7130

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jul 14, 2020
@danielnelson danielnelson added this to the 1.16.0 milestone Jul 14, 2020
@danielnelson danielnelson requested a review from reimda July 14, 2020 19:10
@RemcoAA
Copy link

RemcoAA commented Sep 8, 2020

Hi,

what is the status of this request?

We have tested the INFORM traps with the latest version and I can confirm the traps are being processed by Telegraf, but in the tcpdumps I don't see a reply to the INFORM trap. This is resulting in the device sending the trap multiple times.

@ssoroka ssoroka changed the title Update soniah/gonsmp Update soniah/gosnmp Sep 21, 2020
@ssoroka ssoroka modified the milestones: 1.16.0, Planned Oct 1, 2020
@srebhan
Copy link
Member

srebhan commented Nov 20, 2020

@RemcoAA there are multiple tests-cases failing with the change. The problem can be reproduced locally and is not there with v.1.25.0. These test-cases need to be fixed before this can go any further! The failures are:

--- FAIL: TestReceiveTrap (18.08s)
    --- FAIL: TestReceiveTrap/v3_coldStart_authShaNoPriv (2.02s)
        snmp_trap_test.go:1312: timed out waiting for trap to be received
    --- FAIL: TestReceiveTrap/v3_coldStart_authShaNoPriv#01 (2.00s)
        snmp_trap_test.go:1312: timed out waiting for trap to be received
    --- FAIL: TestReceiveTrap/v3_coldStart_authMD5NoPriv (2.02s)
        snmp_trap_test.go:1312: timed out waiting for trap to be received
    --- FAIL: TestReceiveTrap/v3_coldStart_authSHAPrivAES (2.02s)
        snmp_trap_test.go:1312: timed out waiting for trap to be received
    --- FAIL: TestReceiveTrap/v3_coldStart_authSHAPrivDES (2.00s)
        snmp_trap_test.go:1312: timed out waiting for trap to be received
    --- FAIL: TestReceiveTrap/v3_coldStart_authSHAPrivAES192 (2.02s)
        snmp_trap_test.go:1312: timed out waiting for trap to be received
    --- FAIL: TestReceiveTrap/v3_coldStart_authSHAPrivAES192C (2.00s)
        snmp_trap_test.go:1312: timed out waiting for trap to be received
    --- FAIL: TestReceiveTrap/v3_coldStart_authSHAPrivAES256 (2.00s)
        snmp_trap_test.go:1312: timed out waiting for trap to be received
    --- FAIL: TestReceiveTrap/v3_coldStart_authSHAPrivAES256C (2.00s)
        snmp_trap_test.go:1312: timed out waiting for trap to be received

@srebhan srebhan self-assigned this Nov 21, 2020
@srebhan
Copy link
Member

srebhan commented Dec 3, 2020

@RemcoAA do you see a change to pick this up or anyone else?

@reimda
Copy link
Contributor

reimda commented Jan 7, 2021

#8588 upgraded the gosnmp library and switched to the new home on github at gosnmp/gosnmp.

@reimda reimda closed this Jan 7, 2021
@sspaink sspaink deleted the update-gosnmp branch December 22, 2021 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/snmp feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNMP Trap Inform
5 participants