-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docker input plugin #754
Conversation
75996bd
to
9395b8b
Compare
thanks @titilambert, can you update the README with the new stats? |
Done ! |
the way the metrics are formatted seems a little inconsistent to me, what about like this?
|
7da18f4
to
6ec9d91
Compare
@sparrc you're right ! Changes done ! |
@titilambert hey, looking at the diff just spotted a typo: docker (memeory_total) Nice job btw! |
@tripledes Thanks ! Fixed ! |
} | ||
|
||
// Add metrics | ||
acc.AddFields("docker", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change these to a single call to AddFields():
fields := map[string]interface{}{
"n_cpus": ...
"n_containers": ...
...
}
acc.AddFields("docker", fields, ...)
Done ! I didn't merge |
Hello !
This commit adds
docker info
data in returned metrics and improve test coverage to more than 70%