Fix for perfmon instance_name for #7325 #7526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Elastic pools, sys.dm_os_perfmon_counters has counters for all databases represented by GUIDS. To resolve the GUID to a DB name have to join with sys.databases However sys.database only has a row for the current database.
andrewmitchell21
approved these changes
May 20, 2020
There was a problem hiding this comment.
This change looks good to me, happy to test and provide feedback if needed. Maybes @danielnelson can advise here
|
@andrewmitchell21 Always helpful to have additional testing, here are links to the CI builds of this pull request: |
danielnelson
pushed a commit
that referenced
this pull request
May 21, 2020
(cherry picked from commit 5280023)
3 tasks
rhajek
pushed a commit
to bonitoo-io/telegraf
that referenced
this pull request
Jul 13, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Elastic pools, sys.dm_os_perfmon_counters has counters for all databases represented by GUIDS. To resolve the GUID to a DB name have to join with sys.databases
However sys.database only has a row for the current database and not all databases and hence the instance_name for those rows would be NULL and insert would fail with
"Cannot insert the value NULL error"
Fix is to resolve DB name for the current database, leave the GUID for perfmon counters of other databases.
closes #7325
Required for all PRs: