Flush based on buffer size rather than time #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
force-pushed
the
cs666
branch
2 times, most recently
from
b496d53
to
93106be
Compare
|
Awesome! |
sparrc
force-pushed
the
cs666
branch
3 times, most recently
from
91aaa99
to
18f77bb
Compare
|
@sparrc nice! Thanks, I'll see when I can give it a try. |
sparrc
force-pushed
the
cs666
branch
10 times, most recently
from
3d571ff
to
f8077bc
Compare
sparrc
changed the title
Accumulator to the ServiceInput Start() function
|
@netixen @tripledes this is pretty much ready to go, if you have some time to put some eyes on it and review it would be great :) The changes in the nats_consumer, mqtt_consumer, and kafka_consumer highlight the changes to the service plugins. Then the changes in running_output are the meat of the new flushing method. |
this includes: - Add Accumulator to the Start() function of service inputs - For message consumer plugins, use the Accumulator to constantly add metrics and make Gather a dummy function - rework unit tests to match this new behavior. - make "flush_buffer_when_full" a config option that defaults to true closes #666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #666