Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NATS consumer input plugin. #680

Closed
wants to merge 2 commits into from
Closed

Add NATS consumer input plugin. #680

wants to merge 2 commits into from

Conversation

netixen
Copy link
Contributor

@netixen netixen commented Feb 10, 2016

Used the kafka consumer as a blueprint.
More info about NATS

netixen
netixen reviewed Feb 10, 2016
View reviewed changes
Godeps
@@ -20,17 +18,17 @@ github.com/gorilla/mux 26a6070f849969ba72b72256e9f14cf519751690
github.com/hailocab/go-hostpool e80d13ce29ede4452c43dea11e79b9bc8a15b478
github.com/influxdata/config bae7cb98197d842374d3b8403905924094930f24
github.com/influxdata/influxdb a9552fdd91361819a792f337e5d9998859732a67
github.com/influxdata/telegraf 0109320e226130940cd0b999ea529c05cda49a88
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess 'gdm save' shouldn't do this?

@pires
Copy link
Contributor

pires commented Feb 11, 2016

@netixen even though I can't validate the PR with testing, I did a quick read and congratulations for the amazing job! I know a lot of NATS users will appreciate this.

@bjflanne
Copy link

@netixen second what @pires said! - FYI I am NATS Community Manager. If quick chat with anyone on our team would be useful to you in working on this PR just reach out - we can schedule something, or if you are a Slack user tell me and I will get you in the Slack Community for NATS..

[email protected]

B

@netixen
Copy link
Contributor Author

netixen commented Feb 11, 2016

@pires @bjflanne Thank You. I'm in love with the elegance and speed of NATS. And since influxdb is designed for hundreds of thousands of writes per second, it's a great match. Awesome job from apcera and InfluxData..

@bjflanne
Copy link

Excellent! Yes -- simplicity and performance are two core philosophies NATS was designed around. Where are you located? There's a NATS meetup in San Francisco next month if you'd like to give lightning talk on your plugin happy to give you some time on the agenda. Likewise, if you're a slack user pop me an email and I can get you into the Slack community. Keep up the good work!!!!

B

sparrc
sparrc reviewed Feb 11, 2016
View reviewed changes
plugins/inputs/nats_consumer/nats_consumer.go
### name a queue group
queue_group = "telegraf_consumers"
### Maximum number of points to buffer between collection intervals
point_buffer = 100000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change point_buffer to metric_buffer? I have a PR making this change in the kafka consumer already

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #676

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sparrc Done

@sparrc
Copy link
Contributor

sparrc commented Feb 12, 2016

thanks @netixen, looks good

@sparrc sparrc closed this in 6c353e8 Feb 12, 2016
geodimm pushed a commit to miketonks/telegraf that referenced this pull request Mar 10, 2016
@netixen @geodimm
Change point_buffer to metric_buffer to conform will changes in influ…
d3884d4 
…xdata#676

closes influxdata#680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@netixen @pires @bjflanne @sparrc