Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Graphite line protocol listen, command and tail plugins support... #627

Closed
wants to merge 2 commits into from

Conversation

henrypfhu
Copy link
Contributor

Add three new plugins to support Graphite line protocol:

  1. execline input plugin to support shell command which generate graphite line protocol text contents. This plugin will compatible with nagois/sensue shell command plugins which can generate graphite mertics.
  2. graphite input service plugin to use TCP or UDP listen port to accept graphite line protocol text inputs. This plugin should be compatible with graphite mertic collectors.
  3. tail input service plugin to tail the files to process graphite line protocol texts generated by other graphite metrics generators.

@sparrc
Copy link
Contributor

sparrc commented Feb 1, 2016

@henrypfhu you'll need to separate the plugins into separate PRs, and also some general comments:

  1. execline graphite parsing should be integrated into the existing exec plugin.
  2. You should not have the same code in 3 places, break graphite parsing into it's own package, put it somewhere like internal/encoding/graphite
  3. the "graphite listener" is going to have to wait for now, ideally this would be integrated into Add a generic TCP/UDP line-protocol listener #481.
  4. In general I would like to standardize the JSON/graphite/line-protocol parsing (there will be other formats coming). If you could start this with an internal graphite encoding package, that would be great. I don't think that graphite needs to have it's own plugins just because it's a different encoding. Instead, I think that "generic" type plugins (such as exec and a udp listen plugin) can have the option for users to switch between encodings.

@sofixa
Copy link

sofixa commented Feb 1, 2016

If i might weigh in - i too think it would be a good idea to have a "type" or "format" parameter to the generic exec(and why not http) input plugins, which will default to json, but will also allow xml, graphite, nagios and what not.

@sparrc
Copy link
Contributor

sparrc commented Feb 1, 2016

@sofixa influx line-protocol and json will be supported in 0.10.2, see #617

…af mertic paser to the internal/encoding direcotry.
@henrypfhu
Copy link
Contributor Author

According to @sparrc suggestion, I combined the graphite feature into the exec plugin, and refactor the parser module into internal/encoding directory....

I will open the new PR for this new exec plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants