Initial implementation for multiple outputs

[jipperinbham]

This is sort of a phase one to create an outputs configuration in order to send metrics to more than InfluxDB and begins to address #38.

I'd love some feedback here!

[sparrc]

These will need to be fixed before merging this PR

[sparrc]

@jipperinbham Hi JP, if you want to fix the 2 comments I made and the branch conficts, then I can test this out and merge it!

[jipperinbham]

@sparrc I've updated the import paths to point to influxdb and rebased from master. Please let me know if something isn't building or running properly.

[sparrc]

@jipperinbham It looks like there may have been a merge problem, see ci failure above:

./config.go:220: undefined: ErrInvalidConfig Action failed: go build

[jipperinbham]

sorry about that @sparrc, should be good to test now

[sparrc]

@jipperinbham no prob!

This looks good to me, I like the design and fits with telegraf well.

Two questions, and maybe I'm just not 100% understanding the code, but should the sample and test TOML files be changed from [influxdb] to [outputs] ?

2nd: is there any validation that a valid output was specified? not that it needs to validate that the output destination is connectable, but maybe some validation that the configured output exists as an "output plugin" in telegraf?

PS: you can find those files in etc/config.sample.toml and testdata/influx.toml

[jipperinbham]

re: the sample TOML files, I held off on updating those in case there were some changes I needed to make but will do that now

re: output validation, I'm pretty sure the following covers it

https://github.com/jipperinbham/telegraf/blob/outputs-phase1/agent.go#L83-L86

[sparrc]

@jipperinbham I think you've accidentally added the telegraf binary to your commit, once that's removed I think the PR is good to go 👍

[sparrc]

@jipperinbham I'm anxious to get this merged, are you done with this PR? I think last we left it, you needed to update the Connect() function?

[jipperinbham]

@sparrc yes, it should be good to go. Sorry I forgot to /cc you on that last commit.

I couldn't fully test because I hit the line protocol change for deprecating ints but all the config and tags looked good.

[sparrc]

@jipperinbham I tried to merge this in but had some major conflicts, so I had to revert it, unfortunately I don't think that I'm able to re-open this PR.

Sorry for the hassle, but could you please rebase your changes and re-open a new PR?

[jipperinbham]

@sparrc no problem, I'll rebase and get things cleaned up and submit a new PR

[sparrc]

thanks @jipperinbham! Just to warn you, that is probably going to be a pretty hairy merge/rebase, there have been some pretty large changes in agent.go and config.go.

Let me know if you need a hand and we can walk through it together on Google hangouts if need be

[jipperinbham]

It looks like the issue is here, 29e8ce6, which I'm not entirely sure how to handle since we moved decided to move the Tags to the InfluxDB output and out of Config.

Not entirely sure how to proceed with the changes needed...

[sparrc]

@jipperinbham yes, this is what I was afraid of, I think I may have been wrong to suggest moving that into InfluxDB, and that the Tags should in fact stay in Config.

[jipperinbham]

no worries, I can easily look back through the git commits to move it back, it also makes cleaning up these merge conflicts possible without touching what others have added.