Add carbon2 serializer #5345
Add carbon2 serializer #5345
Conversation
|
Ok, looks like we need to support Go 1.9 which does not have StringBuilders. I'll refactor code to account for that. Any idea on when Telegraf will drop support for 1.9? |
|
Ok great, tests are looking good. Please let me know if you need any changes or have any questions, would love to get this into the earliest release we can. |
|
🥇 I tested this out with numerous inputs and it worked quite well. I would love to see this merged as our project would like to use this w/ SumoLogic instead of the graphite serializer. This makes Telegraf/Sumo configuration trivial w/ HTTP output. |
There was a problem hiding this comment.
Looks good, I just have a few ideas for improving the performance, mostly artifacts from remove StringBuilder. Not sure when we will drop support for Go 1.9, the main sticking point is that Go 1.10 and later don't work on RHEL5, we will probably move if/when it begins to become a larger burden.
|
@danielnelson thanks much for the review and suggestions. Just pushed the updates, will monitor tests but local tests passed. |
|
Nice work, thanks! |
Required for all PRs:
This PR addresses issue #5344 by adding a Carbon2 serializer. Carbon2 is a metrics format supported by multiple applications and vendors. Implementing it as a serializer would allow it to integrate with the existing output plugin ecosystem as well as integrate with any additional vendors who want to add support for the Carbon2 format.