Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ping plugin under bsd variants. #5112

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

AlexanderThaller
Copy link
Contributor

Under version Telegraf 1.9.0 the ping plugin throws the following error under FreeBSD 11.2:

2018-12-05T13:42:50Z E! [inputs.ping]: Error in plugin: host 1.1.1.1: ping: illegal option -- w
usage: ping [-AaDdfnoQqRrv] [-c count] [-G sweepmaxsize] [-g sweepminsize]
            [-h sweepincrsize] [-i wait] [-l preload] [-M mask | time] [-m ttl]
            [-P policy] [-p pattern] [-S src_addr] [-s packetsize] [-t timeout]
            [-W waittime] [-z tos] host
       ping [-AaDdfLnoQqRrv] [-c count] [-I iface] [-i wait] [-l preload]
            [-M mask | time] [-m ttl] [-P policy] [-p pattern] [-S src_addr]
            [-s packetsize] [-T ttl] [-t timeout] [-W waittime]
            [-z tos] mcast-group, exit status 64

This fixes that and changes the flag to -W which was probably intended in that use-case.

Required for all PRs

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

… but a flag -W which was probably desired here.
@glinton glinton added this to the 1.9.1 milestone Dec 6, 2018
@glinton glinton added the fix pr to fix corresponding bug label Dec 6, 2018
@danielnelson danielnelson merged commit 1170367 into influxdata:master Dec 11, 2018
danielnelson pushed a commit that referenced this pull request Dec 11, 2018
trevorwhitney pushed a commit to trevorwhitney/telegraf that referenced this pull request Feb 14, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants