Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Package Updates #497

Merged
merged 3 commits into from
Jan 8, 2016
Merged

WIP - Package Updates #497

merged 3 commits into from
Jan 8, 2016

Conversation

rossmcdonald
Copy link
Contributor

Restructured the package's filesystem hierarchy:

  • Binaries are now located at /usr/bin/
  • Configuration is now located at /etc/telegraf

In addition:

  • Added a build.py script to mirror InfluxDB and Kapacitor.
  • A few fixes and updates to the init.sh script
  • Minor update to the telegraf.service unit file to correct usage of variable
  • Added a post-install.sh and pre-install.sh to handle upgrades and other housekeeping

sparrc and others added 2 commits January 8, 2016 15:25
… pre install scripts to handle installation and upgrades in a cleaner way. Minor fixes to the init script and service unit file.
@rossmcdonald
Copy link
Contributor Author

@sparrc Can you review the CONFIGURATION.md file to make sure I merged it correctly? Apologies if I overwrote anything.

@sparrc
Copy link
Contributor

sparrc commented Jan 8, 2016

Looks good 👍

@sparrc
Copy link
Contributor

sparrc commented Jan 8, 2016

Should we get rid of scripts/package.sh?

@rossmcdonald
Copy link
Contributor Author

Let's leave it in for now in case we run into any issues with the new script. I'd also like to go through and make sure that all functionality is covered in the future before we strip it out. I've done that for InfluxDB, but it looks like Telegraf's is slightly different.

@sparrc
Copy link
Contributor

sparrc commented Jan 8, 2016

cool, LGTM, let me know when it's ready and I'll merge it with the 0.3.0 branch

@rossmcdonald
Copy link
Contributor Author

@sparrc One caveat to the upgrade path (and this is the same with InfluxDB too) is that RHEL/CentOS users upgrading from 0.2 to 0.3 will probably have their configurations overwritten by the upgrade. There is a backup stored at /etc/telegraf/telegraf.conf.$(date +%s).backup, so all they have to do is restore the backup before restarting the service. It's probably not a huge deal since this release has some breaking changes in it anyways, but I wanted to make sure you are aware. This also only pertains to CentOS/RHEL, and not Debian/Ubuntu.

Other than that, I think this is ready to merge.

rossmcdonald added a commit that referenced this pull request Jan 8, 2016
@rossmcdonald rossmcdonald merged commit 231b5fe into 0.3.0 Jan 8, 2016
@sparrc
Copy link
Contributor

sparrc commented Jan 8, 2016

thanks for the heads-up @rossmcdonald, I'll put a note about that in the changelog

@sparrc sparrc deleted the rm-package-updates branch January 11, 2016 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants