Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add certificate subject as a tag #4873

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Add certificate subject as a tag #4873

merged 1 commit into from
Oct 19, 2018

Conversation

onurguzel
Copy link
Contributor

If there is a certificate chain in input source, all certificates are
returned with the same source tag. Subject of the certificate is added
to use all certs in the chain as an input.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson
Copy link
Contributor

I think we should call this tag cn and it could be a nice touch to add other fields if set such as o, ou: https://tools.ietf.org/html/rfc2253#section-2.3

@onurguzel
Copy link
Contributor Author

I think we should call this tag cn

At first, I was using the RDN with Subject.String() (Go 1.10+), and then I modified my commit to use CommonName to be able to build on Go 1.9, leaving tag name subject. Should I rename to common_name or the abbreviation cn?

and it could be a nice touch to add other fields if set such as o, ou

Sounds nice. What do you think about a c (country) tag?

@danielnelson
Copy link
Contributor

I guess using the longer name instead of the abbreviation would be better, especially when considering the one letter abbrevs. I think we could do any/all of these:

  • common_name
  • locality
  • province
  • organization
  • organization_unit
  • country

@glinton glinton mentioned this pull request Oct 18, 2018
3 tasks
If there is a certificate chain in input source, all certificates are
returned with the same source tag. DN of the certificate is added to
use all certs in the chain as an input.
@onurguzel
Copy link
Contributor Author

I have added all the tags you requested.

@glinton glinton added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Oct 18, 2018
@glinton glinton added this to the 1.9.0 milestone Oct 18, 2018
@danielnelson danielnelson merged commit d331163 into influxdata:master Oct 19, 2018
@danielnelson danielnelson modified the milestones: 1.9.0, 1.8.3 Oct 19, 2018
@danielnelson
Copy link
Contributor

Thanks, I'll update the readme and I'm going to add this to 1.8.3 since this is critical for the plugin to work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants