Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3911 Add telegraf version to User-Agent header for http requests #4838

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

kevinconaway
Copy link
Contributor

Required for all PRs:

  • [ Y] Signed CLA.
  • [ NA] Associated README.md updated.
  • [ Y] Has appropriate unit tests.

@danielnelson This PR adds a User-Agent: Telegraf X.Y.Z version to outbound http requests for the following output plugins:

  • http
  • influxdb
  • influxdb_v2

@@ -10,6 +10,8 @@ import (
"testing"
"time"

"github.com/influxdata/telegraf/internal"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import can be grouped with the other influxdata/telegraf ones

@glinton glinton added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Oct 10, 2018
@glinton glinton added this to the 1.9.0 milestone Oct 10, 2018
Copy link
Contributor

@danielnelson danielnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed in the issue that I suggested using a slash instead of a space Telegraf/1.8.2, I think we should use the slash to be more compliant with https://tools.ietf.org/html/rfc2616#section-14.43 by using a product token

@kevinconaway
Copy link
Contributor Author

kevinconaway commented Oct 11, 2018

@danielnelson Thanks, I learned something new today re: product tokens. I've incorporated that feedback as well as fixed the ungrouped import per @glinton's feedback

@danielnelson danielnelson merged commit 44fd74d into influxdata:master Oct 11, 2018
rgitzel pushed a commit to rgitzel/telegraf that referenced this pull request Oct 17, 2018
Header is added in influxdb, influxdb_v2, and http outputs.
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
Header is added in influxdb, influxdb_v2, and http outputs.
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
Header is added in influxdb, influxdb_v2, and http outputs.
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
Header is added in influxdb, influxdb_v2, and http outputs.
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Header is added in influxdb, influxdb_v2, and http outputs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants