Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Procstat plugin add win_service option to lookup the specified service process pid #4811

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Procstat plugin add win_service option to lookup the specified service process pid #4811

merged 2 commits into from
Oct 5, 2018

Conversation

pytimer
Copy link
Contributor

@pytimer pytimer commented Oct 4, 2018

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

This PR implement #4209. Add win_service option to lookup the specified service process pid.

@pytimer pytimer mentioned this pull request Oct 4, 2018
Closed
@glinton glinton added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin area/procstat labels Oct 4, 2018
glinton
glinton suggested changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to move out the windows specific code into a new procstat_windows.go file as all go files in golang.org/x/sys/windows/svc/mgr have windows only build tags.

@pytimer
Copy link
Contributor Author

pytimer commented Oct 5, 2018

@glinton Thanks for you reply.

I move the windows specific code into a new win_service_windows.go file, you can check it if there is a problem. Thanks.

@danielnelson danielnelson added this to the 1.9.0 milestone Oct 5, 2018
@danielnelson danielnelson merged commit f81696b into influxdata:master Oct 5, 2018
rgitzel pushed a commit to rgitzel/telegraf that referenced this pull request Oct 17, 2018
@pytimer @rgitzel
Add windows service name lookup to procstat input (influxdata#4811)
82b0461
glinton added a commit that referenced this pull request Oct 29, 2018
@glinton
Minor updates for procstat win_service #4811
49ca7f4
danielnelson pushed a commit that referenced this pull request Nov 5, 2018
@glinton @danielnelson
Fix toml struct tag in win_service #4811 (#4936)
74667cd
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
@pytimer @otherpirate
Add windows service name lookup to procstat input (influxdata#4811)
ba19e68
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
@glinton @otherpirate
Fix toml struct tag in win_service influxdata#4811 (influxdata#4936)
3937293
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
@pytimer @otherpirate
Add windows service name lookup to procstat input (influxdata#4811)
5b74cff
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
@glinton @otherpirate
Fix toml struct tag in win_service influxdata#4811 (influxdata#4936)
0577a51
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
@pytimer
Add windows service name lookup to procstat input (influxdata#4811)
0494c6c
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
@glinton
Fix toml struct tag in win_service influxdata#4811 (influxdata#4936)
629fc3d
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@pytimer
Add windows service name lookup to procstat input (influxdata#4811)
cd6c370
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@glinton
Fix toml struct tag in win_service influxdata#4811 (influxdata#4936)
646efab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glinton glinton glinton approved these changes

Assignees
No one assigned
Labels
area/procstat feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pytimer @glinton @danielnelson