Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #4764 (Panic when error during call to GetAvailableMetrics) #4765

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Fixed #4764 (Panic when error during call to GetAvailableMetrics) #4765

merged 1 commit into from
Sep 28, 2018

Conversation

prydin
Copy link
Contributor

@prydin prydin commented Sep 27, 2018

This is a fix for #4764

If a network error is encountered while querying for metric metadata, it is possible to get a panic due to a typo in endpoint.go (Unlock instead of Lock).

https://github.com/influxdata/telegraf/blob/af0ef55c0281af67fe2db52d8c700fa8f636010e/plugins/inputs/vsphere/endpoint.go#L660-666

Required for all PRs:

  • [ X] Signed CLA.
  • [ X] Associated README.md updated.
  • [ X] Has appropriate unit tests.

@danielnelson danielnelson added this to the 1.8.1 milestone Sep 27, 2018
@danielnelson danielnelson added the fix pr to fix corresponding bug label Sep 27, 2018
@danielnelson danielnelson merged commit c369c19 into influxdata:master Sep 28, 2018
danielnelson pushed a commit that referenced this pull request Sep 28, 2018
@prydin prydin deleted the vsphere-1.8-fix1 branch September 28, 2018 02:28
@randallt
Copy link

randallt commented Oct 3, 2018

I have to go through a lengthy process to get RPMs approved for my environment, and would like this bug fix included.
Is there a target date for the 1.8.1 release?

@danielnelson
Copy link
Contributor

Planning to do it today.

rgitzel pushed a commit to rgitzel/telegraf that referenced this pull request Oct 17, 2018
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vsphere fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants