-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Message Max bytes configuration #4537
Add Message Max bytes configuration #4537
Conversation
What happens if the message is over the max, does |
When message is bigger than MessageMaxBytes config this error occurs: It's the same error with default value(without configuration) |
It seems like short term we ought to drop these messages, after logging, because otherwise the output plugin will just be stuck trying to send with no potential to send successfully. I don't think this needs to be done in the PR though. Long term, I would like to add a max size limitation to the Serializer interface. This way we could attempt to split the messages, similar to how we can currently limit single lines in the influx serializer. We would have to consider what this means for each serializer and ultimately it still may impossible to write some metrics in the allotted space. |
cherry-picked to master 61513c6 |
Required for all PRs: