Logparser divide by zero #4338
Merged
Logparser divide by zero #4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glinton
approved these changes
Jun 28, 2018
|
I like defaulting the year to the current year, seems very unlikely anyone legitimately has logs in year 0, but I think there may be additional paths that could cause the crash such as in the One issue though is that this still leaves the panic in tsMod, and I think it will be easy to have regressions if this code is modified. Is it possible to fix the bug in that function so that any time.Time can be passed in? |
glinton
approved these changes
Jul 26, 2018
danielnelson
suggested changes
Jul 26, 2018
added 3 commits
August 24, 2018 17:29
danielnelson
force-pushed
the
logparser-divide-by-zero
branch
from
895c120
to
0a11b4b
Compare
danielnelson
approved these changes
Aug 25, 2018
rgitzel
pushed a commit
to rgitzel/telegraf
that referenced
this pull request
Oct 17, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3438