Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input plugin for collect meminfo data #4304

Closed
wants to merge 2 commits into from

Conversation

shrug42
Copy link
Contributor

@shrug42 shrug42 commented Jun 15, 2018

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson
Copy link
Contributor

The mem plugin already reads /proc/meminfo, but doesn't current return all the fields. Could you open an issue on gopsutil to see if they would accept a pull request parsing the extra fields in mem.VirtualMemory()? We could then hook up the extra fields in the mem plugin.

https://github.com/shirou/gopsutil/blob/master/mem/mem_linux.go#L18

@shrug42
Copy link
Contributor Author

shrug42 commented Jun 19, 2018

Sure, let me try a PR on their side.

@shrug42
Copy link
Contributor Author

shrug42 commented Jun 19, 2018

I will follow up with them (shirou/gopsutil#539)
I will give you another PR if it succeeds.

@danielnelson danielnelson mentioned this pull request Aug 9, 2018
3 tasks
@danielnelson
Copy link
Contributor

@shrug42 I see your PR to gopsutil went through, are you still working on this plugin?

@shrug42
Copy link
Contributor Author

shrug42 commented Aug 10, 2018

Sorry, I was waiting for the gosputil realese to come through to upgrade the version in telegraf.
And I got busy.
will resume this.

@shrug42
Copy link
Contributor Author

shrug42 commented Aug 11, 2018

I will close this PR in favor of #4546

@danielnelson danielnelson requested a review from glinton August 12, 2018 23:29
@shrug42 shrug42 closed this Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants