-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker input server version #4035
Conversation
@rdxmb Can you review? |
Oh, I am not a Go-developer, so I cannot make a "real review". But, I can have a look at it, of course. What I think about is if we need the tag really with all measurements. Having it with |
Hmm, maybe it should be a string field then, what sort of queries are you planning to use? |
As mostly the strings I use are stored as tags, I did not have the idea to use a string field for that. However, for anybody else a use-case could also be to get what engine-version is running under a container. For that, your PR would be the best. My personal use case is to just check if the docker-engines are up-to-date. So for now I am very flexible about the query. |
I think having it as a tag to all of the docker_* measurements will end up be the least confusing. |
closes #4029
Required for all PRs: