uint64 support #3946
Merged
uint64 support #3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielnelson went with the influxdb approach of gating the feature behind a build flag. |
| @@ -16,6 +16,12 @@ func Metric(v telegraf.Metric, err error) telegraf.Metric { | |||
| return v | |||
| } | |||
|
|
|||
| const ( | |||
| Uint64Overflow uint64 = 9223372036854775808 | |||
There was a problem hiding this comment.
Shouldn't this be larger than Uint64Max? We need to test 18446744073709551616.
There was a problem hiding this comment.
That was to verify Int64Max+1 properly typed to uint64. If we attempt to define a const that’s Uint64Max+1 it’d error on compile.
danielnelson
added
the
feat
|
I did some follow-up work, if you can review: #3948 |
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't see an appropriate README to update.
Pull adds uint64 support for InfluxDB line protocols (in and out), and to telegraf/metric. telegraf metric uint64 support is gated behind a build flag until infludata/influxdb mainline uint64 is generally available to ensure behavior is consistent with how telegraf has behaved in the past.
That will likely be a breaking change in the future unless the API for AddField and convertField are extended so the caller can specify whether or not uint64 storage and, by extension output, is desired.
Required for all PRs: