Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riemann output #379

Merged
merged 3 commits into from
Nov 18, 2015
Merged

Riemann output #379

merged 3 commits into from
Nov 18, 2015

Conversation

sparrc
Copy link
Contributor

@sparrc sparrc commented Nov 18, 2015

cc @allenj

@sparrc
Copy link
Contributor Author

sparrc commented Nov 18, 2015

@allenj I took your commit and added the godep dependencies as well as the docker container. You can see in the 3rd commit that I also removed some of the object reference/dereferencing by mostly storing and passing pointers, which should be more performant as well.

Let me know what you think, and if it looks good I'll merge it to master, thanks a bunch for your contribution!! a lot of people have been asking for this 👍

@allenj
Copy link
Contributor

allenj commented Nov 18, 2015

Looks good. Thanks @sparrc . First thing I've written in golang so I'm glad you looked over and fixed those references/derefs.

@sparrc sparrc merged commit a3feddd into master Nov 18, 2015
@sparrc sparrc deleted the riemann-output branch November 18, 2015 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants