Add server option to unbound plugin #3713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcfedr
force-pushed
the
unbound-server
branch
from
233eed2
to
66a5574
Compare
plugins/inputs/unbound/unbound.go
Outdated
| cmdArgs := []string{"stats_noreset"} | ||
|
|
||
| if Server != "" { | ||
| // Unbound control requires an IP address, and we want to be nice to the user | ||
| serverIp, err := net.LookupIP(Server) |
There was a problem hiding this comment.
I think you will need to net.SplitHostPort and pass in only the host here.
plugins/inputs/unbound/unbound.go
Outdated
|
|
||
| ## IP of server to connect to, read from unbound conf default, optionally '@port' | ||
| ## Will lookup IP if given a hostname | ||
| server = "127.0.0.1@8953" |
plugins/inputs/unbound/unbound.go
Outdated
| cmdArgs := []string{"stats_noreset"} | ||
|
|
||
| if Server != "" { | ||
| // Unbound control requires an IP address, and we want to be nice to the user | ||
| serverIp, err := net.LookupIP(Server) |
There was a problem hiding this comment.
Use a resolver that can accept a timeout.
- Use Resolver with Timeout - Split port from host before resolving
|
@danielnelson How does it look now? I've been using it in production for last couple of weeks now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows unbound plugin to connect to other servers
Required for all PRs: