add ZFS plugin #341
Closed
add ZFS plugin #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for _, metric := range kstatMetrics { | ||
| lines, err := common.ReadLines(kstatPath + "/" + metric) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
We shouldn't panic all of Telegraf here, probably should just return err
|
I can add and the others, but these more demanded |
|
@cornerot don't worry about the other stats, but I need you to remove the panic before I can merge this. Could you also do me a favor and update the README and CHANGELOG? thanks much! |
|
ok! |
added 2 commits
November 9, 2015 15:19
added zfs plugin to README.md
|
CHANGELOG string: |
allenj
pushed a commit
to allenj/telegraf
that referenced
this pull request
Nov 18, 2015
also added zfs plugin to README.md closes influxdata#341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#317