Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS lookup before ping #3345

Closed
wants to merge 1 commit into from
Closed

DNS lookup before ping #3345

wants to merge 1 commit into from

Conversation

vlasad
Copy link
Contributor

@vlasad vlasad commented Oct 17, 2017

@ghost
Copy link

ghost commented Oct 17, 2017

I think the goal here is to add the failure in as a metric (field or tag) somehow, per the discussion in #3333

@danielnelson what do you reckon (given the various very valid points in that thread) is the best thing to do with this in the short term? I'm a little torn but to be honest, we dont mind - any of the options are way better than what we have today ;-)

@danielnelson
Copy link
Contributor

I think we will want to send something in the metric instead of just returning an error. Also, we won't want to use the dns_query plugin or the testutil Accumulator. Let's continue discussing over on #3333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants