Fix support for mongodb urls without scheme #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
force-pushed
the
fix-mongodb-url
branch
2 times, most recently
from
8633439
to
64a88fa
Compare
This was broken by changes in go 1.8 to url.Parse. This change allows the string but prompts the user to move to the correct url string.
danielnelson
force-pushed
the
fix-mongodb-url
branch
from
64a88fa
to
376a424
Compare
danielnelson
added a commit
that referenced
this pull request
Jun 9, 2017
This was broken by changes in go 1.8 to url.Parse. This change allows the string but prompts the user to move to the correct url string. (cherry picked from commit b277e6e)
jeichorn
pushed a commit
to jeichorn/telegraf
that referenced
this pull request
Jul 24, 2017
This was broken by changes in go 1.8 to url.Parse. This change allows the string but prompts the user to move to the correct url string.
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
This was broken by changes in go 1.8 to url.Parse. This change allows the string but prompts the user to move to the correct url string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by changes in go 1.8 to url.Parse. This change allows
the string but prompts the user to move to the correct url string.
Fixes #2888
Required for all PRs: