Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL input plugin - log a warning when failing to parse field values #2855

Merged
merged 1 commit into from
May 26, 2017

Conversation

m4ce
Copy link
Contributor

@m4ce m4ce commented May 25, 2017

Solves #2836

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Copy link
Contributor

@danielnelson danielnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably use Accumulator.AddError instead of logging directly, even though the log level will be E!.

I hope this is not going to be spam the logfile if something is wrong. Maybe we should just log once at the end with a list of items that could not be parsed?

@danielnelson danielnelson added this to the 1.4.0 milestone May 26, 2017
@m4ce
Copy link
Contributor Author

m4ce commented May 26, 2017

@danielnelson - I've changed it to use Accumulator.AddError instead.

@danielnelson danielnelson merged commit 02d1687 into influxdata:master May 26, 2017
vlamug pushed a commit to vlamug/telegraf that referenced this pull request May 30, 2017
jeichorn pushed a commit to jeichorn/telegraf that referenced this pull request Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants